Merge latest from apache:lyft-develop #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated local dev instructions to include missing step * First pass at type annotations
* Feature flag for client cache * Fix integration test * Revert "Fix integration test" This reverts commit 58434ab. * Feature flag for client cache * Fix integration tests * Add feature flag to config.py * Add another feature check * Fix more integration tests
* SUPERSET-7: Docker compose config version breaks on Ubuntu 16.04 * SUPERSET-8: Extra text in docs copyright footer
* Store last selected dashboard in sessionStorage * Fix tests
* Added living goods as among the users of Superset Living Goods is a non profit organisation with operation in africa and the middle east. We work in community health use data heavily on day to day. Superset is our platform of choice for dashboards. * Update README.md
* Bump FAB to 2.0.0 * [tests] whitelist SecurityApi login and refresh endpoints * [style] Fix, C812 missing trailing commas * [security] Remove SUPERSET_UPDATE_PERMS flag Registering sources needs to be performed after the views are initialized on UPDATE_PERMS=False configuration * [docs] New, FAB_UPDATE_PERMS and flask fab cli * [docs] Fix, db upgrade needs to come first, create-admin needs a db * [cli] New, superset init bootstraps all permissions for FAB and Superset * [style] Fix, flakes
* [WiP]refactor out a controlUtils.js file * unit tests * add missing license * Addressing comments
* Merge lastest from master into lyft-release-sp8 (apache#7405) * filter out all nan series (apache#7313) * improve not rich tooltip (apache#7345) * Create issue_label_bot.yaml (apache#7341) * fix: do not save colors without a color scheme (apache#7347) * [wtforms] Strip leading/trailing whitespace (apache#7084) * [schema] Updating the datasources schema (apache#5451) * limit tables/views returned if schema is not provided (apache#7358) * limit tables/views returned if schema is not provided * fix typo * improve code performance * handle the case when table name or view name does not present a schema * Add type anno (apache#7342) * Updated local dev instructions to include missing step * First pass at type annotations * [schema] Updating the base column schema (apache#5452) * Update 937d04c16b64_update_datasources.py (apache#7361) * Feature flag for client cache (apache#7348) * Feature flag for client cache * Fix integration test * Revert "Fix integration test" This reverts commit 58434ab. * Feature flag for client cache * Fix integration tests * Add feature flag to config.py * Add another feature check * Fix more integration tests * Fix raw HTML in SliceAdder (apache#7338) * remove backendSync.json (apache#7331) * [bubbles] issue when using duplicated metrics (apache#7087) * SUPERSET-7: Docker compose config version breaks on Ubuntu 16.04 (apache#7359) * SUPERSET-8: Update text in docs copyright footer (apache#7360) * SUPERSET-7: Docker compose config version breaks on Ubuntu 16.04 * SUPERSET-8: Extra text in docs copyright footer * [schema] Adding commits and removing unnecessary foreign-key definitions (apache#7371) * Store last selected dashboard in sessionStorage (apache#7181) * Store last selected dashboard in sessionStorage * Fix tests * [schema] Updating the base metric schema (apache#5453) * Fix NoneType bug & fill the test recipients with original recipients if empty (apache#7365) * feat: see Presto row and array data types (apache#7391) * feat: see Presto row and array data types * fix: address PR comments * fix: lint and build issues * fix: add types * add stronger type hints where possible * fix: lint issues and add select_star func in Hive * add missing pkg init * fix: build issues * fix: pylint issues * fix: use logging instead of print
* Added additional German translations to string file Updates to German translation files as per directions * Removed messages.json
* Merge lastest from master into lyft-release-sp8 (apache#7405) * filter out all nan series (apache#7313) * improve not rich tooltip (apache#7345) * Create issue_label_bot.yaml (apache#7341) * fix: do not save colors without a color scheme (apache#7347) * [wtforms] Strip leading/trailing whitespace (apache#7084) * [schema] Updating the datasources schema (apache#5451) * limit tables/views returned if schema is not provided (apache#7358) * limit tables/views returned if schema is not provided * fix typo * improve code performance * handle the case when table name or view name does not present a schema * Add type anno (apache#7342) * Updated local dev instructions to include missing step * First pass at type annotations * [schema] Updating the base column schema (apache#5452) * Update 937d04c16b64_update_datasources.py (apache#7361) * Feature flag for client cache (apache#7348) * Feature flag for client cache * Fix integration test * Revert "Fix integration test" This reverts commit 58434ab. * Feature flag for client cache * Fix integration tests * Add feature flag to config.py * Add another feature check * Fix more integration tests * Fix raw HTML in SliceAdder (apache#7338) * remove backendSync.json (apache#7331) * [bubbles] issue when using duplicated metrics (apache#7087) * SUPERSET-7: Docker compose config version breaks on Ubuntu 16.04 (apache#7359) * SUPERSET-8: Update text in docs copyright footer (apache#7360) * SUPERSET-7: Docker compose config version breaks on Ubuntu 16.04 * SUPERSET-8: Extra text in docs copyright footer * [schema] Adding commits and removing unnecessary foreign-key definitions (apache#7371) * Store last selected dashboard in sessionStorage (apache#7181) * Store last selected dashboard in sessionStorage * Fix tests * [schema] Updating the base metric schema (apache#5453) * Fix NoneType bug & fill the test recipients with original recipients if empty (apache#7365) * feat: see Presto row and array data types (apache#7391) * feat: see Presto row and array data types * fix: address PR comments * fix: lint and build issues * fix: add types * Incorporate feedback from initial PR (prematurely merged to lyft-release-sp8) (apache#7415) * add stronger type hints where possible * fix: lint issues and add select_star func in Hive * add missing pkg init * fix: build issues * fix: pylint issues * fix: use logging instead of print * feat: view presto row objects in data grid * fix: address feedback * fix: spacing
* Merge lastest from master into lyft-release-sp8 (apache#7405) * filter out all nan series (apache#7313) * improve not rich tooltip (apache#7345) * Create issue_label_bot.yaml (apache#7341) * fix: do not save colors without a color scheme (apache#7347) * [wtforms] Strip leading/trailing whitespace (apache#7084) * [schema] Updating the datasources schema (apache#5451) * limit tables/views returned if schema is not provided (apache#7358) * limit tables/views returned if schema is not provided * fix typo * improve code performance * handle the case when table name or view name does not present a schema * Add type anno (apache#7342) * Updated local dev instructions to include missing step * First pass at type annotations * [schema] Updating the base column schema (apache#5452) * Update 937d04c16b64_update_datasources.py (apache#7361) * Feature flag for client cache (apache#7348) * Feature flag for client cache * Fix integration test * Revert "Fix integration test" This reverts commit 58434ab. * Feature flag for client cache * Fix integration tests * Add feature flag to config.py * Add another feature check * Fix more integration tests * Fix raw HTML in SliceAdder (apache#7338) * remove backendSync.json (apache#7331) * [bubbles] issue when using duplicated metrics (apache#7087) * SUPERSET-7: Docker compose config version breaks on Ubuntu 16.04 (apache#7359) * SUPERSET-8: Update text in docs copyright footer (apache#7360) * SUPERSET-7: Docker compose config version breaks on Ubuntu 16.04 * SUPERSET-8: Extra text in docs copyright footer * [schema] Adding commits and removing unnecessary foreign-key definitions (apache#7371) * Store last selected dashboard in sessionStorage (apache#7181) * Store last selected dashboard in sessionStorage * Fix tests * [schema] Updating the base metric schema (apache#5453) * Fix NoneType bug & fill the test recipients with original recipients if empty (apache#7365) * feat: see Presto row and array data types (apache#7391) * feat: see Presto row and array data types * fix: address PR comments * fix: lint and build issues * fix: add types * Incorporate feedback from initial PR (prematurely merged to lyft-release-sp8) (apache#7415) * add stronger type hints where possible * fix: lint issues and add select_star func in Hive * add missing pkg init * fix: build issues * fix: pylint issues * fix: use logging instead of print * feat: view presto row objects in data grid * fix: address feedback * fix: spacing * Workaround for no results returned (apache#7442) * feat: view presto row objects in data grid (apache#7436) * feat: view presto row objects in data grid * fix: address feedback * fix: spacing * feat: Scheduling queries from SQL Lab (apache#7416) * Lightweight pipelines POC * Add docs * Minor fixes * Remove Lyft URL * Use enum * Minor fix * Fix unit tests * Mark props as required
…query is valid for the chosen database (apache#7422) (apache#7462) merge from lyft-release-sp8 to master
* Late import for optional lib pyhive * fix
Fixing a set of examples that trip on ValueError vs TypeError
…mes (apache#7297) * Bugfix to SQL Lab to support tables and schemas with characters that require quoting * Remove debugging prints * Add uri encoding to secondary tables call * Quote schema names for presto * Quote selected_schema on Snowflake, MySQL and Hive * Remove redundant parens * Add python unit tests * Add js unit test * Fix flake8 linting error
…visible (apache#7233) * trigger query when chart is visible * add integration test
Merge lyft-release-sp8@7bfe7bc to master
* add chinese translate * edit chinese translation
After the following PyDruid change (contained in version 0.5.2) the Superset Histogram charts rendered with Druid data are broken: druid-io/pydruid@0a59a70 Bump the pydruid requirements accordingly in setup.py Issue: apache#7368
* add chinese translate * edit chinese translation * Add Chinese translation * Revised Chinese translation * restore .json
…pache#7485) * Break line before LIMIT statement to prevent trailing comment issue This may not be a perfect solution but it addresses the issue in 7483 closes apache#7483 * fix tests
* Flatten MapChartPreset, HierarchyChartPreset, and CommonChartPreset charts into LegacyChartPreset class * Rename LegacyChartPreset class to MainPreset to reflect new chart preset hierarchy
) * [WIP] Live query validation, where supported This builds on apache#7422 to build check-as-you-type sql query validation in Sql Lab. This closes apache#6707 too. It adds a (debounced) call to the validate_sql_json API endpoint with the querytext, and on Lyft infra is able to return feedback to the user (end to end) in $TBD seconds. At present feedback is provided only through the "annotations" mechanism build in to ACE, although I'd be open to adding full text elsewhere on the page if there's interest. * fix: Unbreak lints and tests
…#7517) This change makes the query progress bar only show whole number percentage changes, instead of numbers like 12.13168276%.
* Validate start/end when scheduling queries * Use chrono instead of Sugar
* Show scheduled queries * Remove column * Secure views * Add import * Fix unit tests * Reuse existing db connection from view * Remove unnecessary import
Codecov Report
@@ Coverage Diff @@
## lyft-master #36 +/- ##
===============================================
+ Coverage 64.29% 72.71% +8.41%
===============================================
Files 444 85 -359
Lines 21896 11288 -10608
Branches 2414 0 -2414
===============================================
- Hits 14079 8208 -5871
+ Misses 7683 3080 -4603
+ Partials 134 0 -134
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.