fixed cache issue for query v1 #7507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7507 +/- ##
=======================================
Coverage 65.43% 65.43%
=======================================
Files 432 432
Lines 21319 21319
Branches 2347 2347
=======================================
Hits 13951 13951
Misses 7252 7252
Partials 116 116
Continue to review full report at Codecov.
|
kristw
approved these changes
May 14, 2019
michellethomas
pushed a commit
that referenced
this pull request
May 15, 2019
(cherry picked from commit fda1002)
|
thanks @conglei !!! |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 31, 2019
(cherry picked from commit fda1002)
michellethomas
pushed a commit
that referenced
this pull request
Jun 1, 2019
(cherry picked from commit fda1002)
mistercrunch
added
🏷️ bot
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
(cherry picked from commit b19d0fb)
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
(cherry picked from commit b19d0fb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
In this PR, it fixed the issue that
cache_valueis reassigned to a binary blob, which causes the invalid access to its keys.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
Tested in Dev Box
ADDITIONAL INFORMATION
REVIEWERS
@kristw