chore: Truncate progressbar percentage decimals #7499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes the query progress bar only show whole number percentage changes, instead of numbers like 12.13168276%.
khtruong
approved these changes
May 13, 2019
Codecov Report
@@ Coverage Diff @@
## lyft-release-sp8 #7499 +/- ##
=================================================
Coverage 65.27% 65.27%
=================================================
Files 435 435
Lines 21389 21389
Branches 2357 2357
=================================================
Hits 13961 13961
Misses 7308 7308
Partials 120 120
Continue to review full report at Codecov.
|
bearcage
pushed a commit
to bearcage/incubator-superset
that referenced
this pull request
May 15, 2019
This change makes the query progress bar only show whole number percentage changes, instead of numbers like 12.13168276%.
betodealmeida
pushed a commit
that referenced
this pull request
May 15, 2019
bearcage
pushed a commit
to bearcage/incubator-superset
that referenced
this pull request
May 15, 2019
…#7517) This change makes the query progress bar only show whole number percentage changes, instead of numbers like 12.13168276%.
xtinec
pushed a commit
that referenced
this pull request
May 15, 2019
mistercrunch
added
🏷️ bot
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
This change makes the query progress bar only show whole number percentage changes, instead of numbers like 12.13168276%.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
This change makes the query progress bar only show
whole number percentage changes, instead of numbers
like 12.13168276%.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
It's a little tricky to catch this one in action for a screenshot. Slow sample queries welcome...
TEST PLAN
Run a slow query or table preview and watch the progress bar display a crazy number
ADDITIONAL INFORMATION
REVIEWERS
@betodealmeida @khtruong