Flatten legacy preset charts #7500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7500 +/- ##
==========================================
+ Coverage 65.42% 65.43% +0.01%
==========================================
Files 435 432 -3
Lines 21325 21319 -6
Branches 2347 2347
==========================================
Hits 13951 13951
+ Misses 7258 7252 -6
Partials 116 116
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #7500 +/- ##
==========================================
+ Coverage 65.42% 65.43% +0.01%
==========================================
Files 435 432 -3
Lines 21325 21319 -6
Branches 2347 2347
==========================================
Hits 13951 13951
+ Misses 7258 7252 -6
Partials 116 116
Continue to review full report at Codecov.
|
…harts into LegacyChartPreset class
kristw
approved these changes
May 14, 2019
|
Let's rename |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
SUMMARY
Refactor CommonChartPreset, HierarchyChartPreset, and MapChartPreset charts into MainPreset class. This provides a central location to add and remove chart plugins, and will aid maintenance of legacy chart presets now that they are all in one location.
ADDITIONAL INFORMATION
REVIEWERS
@kristw