Skip to content

Commit

Permalink
Convert EpoxyVisibilityTracker code to Kotlin (#1090)
Browse files Browse the repository at this point in the history
* IDE convert for EpoxyVisibilityTracker

* Remove generated !!

* ktlint format

* remove 1 warning

* Fix :epoxy-integrationtest:compileReleaseUnitTestKotlin

* Update epoxy-adapter/src/main/java/com/airbnb/epoxy/EpoxyVisibilityTracker.kt

Co-authored-by: Peter Elliott <pelliott19@gmail.com>

* Update epoxy-adapter/src/main/java/com/airbnb/epoxy/EpoxyVisibilityTracker.kt

Co-authored-by: Peter Elliott <pelliott19@gmail.com>

* Update epoxy-adapter/src/main/java/com/airbnb/epoxy/EpoxyVisibilityTracker.kt

Co-authored-by: Peter Elliott <pelliott19@gmail.com>

* `EpoxyVisibilityItem` rework generated constructor

* Replace `String.format` by Kotlin substitution

* reduce indent

* minor fixes (comments and kotlin friendly)

* shorten and use `val`

* Fix `EpoxyVisibilityItemTest.kt`

* `val isInFocusVisible` to `fun isInFocusVisible()`

* minor fix in test log output

* Update epoxy-adapter/src/main/java/com/airbnb/epoxy/EpoxyVisibilityItem.kt

Co-authored-by: Peter Elliott <pelliott19@gmail.com>

* Update epoxy-adapter/src/main/java/com/airbnb/epoxy/EpoxyVisibilityTracker.kt

Co-authored-by: Peter Elliott <pelliott19@gmail.com>

* NOT_NOTIFIED -> null

* onChangedEnabled / partialImpressionThresholdPercentage as var

Co-authored-by: Emmanuel Boudrant <eboudrant@netflix.com>
Co-authored-by: Peter Elliott <pelliott19@gmail.com>
  • Loading branch information
3 people authored Nov 22, 2020
1 parent e647d96 commit 5003de2
Show file tree
Hide file tree
Showing 7 changed files with 700 additions and 747 deletions.
204 changes: 0 additions & 204 deletions epoxy-adapter/src/main/java/com/airbnb/epoxy/EpoxyVisibilityItem.java

This file was deleted.

Loading

0 comments on commit 5003de2

Please sign in to comment.