Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0.0.beta1 generating duplicate method layout(int) #988

Closed
markchristopherng opened this issue May 29, 2020 · 3 comments · Fixed by #991
Closed

4.0.0.beta1 generating duplicate method layout(int) #988

markchristopherng opened this issue May 29, 2020 · 3 comments · Fixed by #991

Comments

@markchristopherng
Copy link

markchristopherng commented May 29, 2020

Hi

The 4.0.0.beta1 version is generating duplicate methods on the builder. When i downgrade to 3.11.0 it goes away.

In the console i get an error like this

method layout(int) is already defined in class EpoxyOfflineArticles_
public EpoxyOfflineArticles_ layout(@LayoutRes int layoutRes) {

When i open up the generated class you can see the duplicated method

public interface EpoxyArticlesBuilder {
EpoxyArticlesBuilder onBind(OnModelBoundListener<EpoxyArticles_, TrackItemRowView> listener);

EpoxyArticlesBuilder onUnbind(OnModelUnboundListener<EpoxyArticles_, TrackItemRowView> listener);

EpoxyArticlesBuilder onVisibilityStateChanged(
OnModelVisibilityStateChangedListener<EpoxyArticles_, TrackItemRowView> listener);

EpoxyArticlesBuilder onVisibilityChanged(
OnModelVisibilityChangedListener<EpoxyArticles_, TrackItemRowView> listener);

EpoxyArticlesBuilder consignmentWrapper(
@nullable NonEqualWrapper consignmentWrapper);

EpoxyArticlesBuilder itemViewListener(@nullable ActionableTrackItemListener itemViewListener);

EpoxyArticlesBuilder layout(@LayoutRes int layoutRes);

EpoxyArticlesBuilder id(long id);

EpoxyArticlesBuilder id(@androidx.annotation.Nullable Number... ids);

EpoxyArticlesBuilder id(long id1, long id2);

EpoxyArticlesBuilder id(@androidx.annotation.Nullable CharSequence key);

EpoxyArticlesBuilder id(@androidx.annotation.Nullable CharSequence key,
@androidx.annotation.Nullable CharSequence... otherKeys);

EpoxyArticlesBuilder id(@androidx.annotation.Nullable CharSequence key, long id);

EpoxyArticlesBuilder layout(@LayoutRes int layoutRes);

EpoxyArticlesBuilder spanSizeOverride(
@androidx.annotation.Nullable EpoxyModel.SpanSizeOverrideCallback spanSizeCallback);
}

@markchristopherng markchristopherng changed the title 4.0.0.beta generating duplicate method layout(int) 4.0.0.beta1 generating duplicate method layout(int) May 29, 2020
@markchristopherng
Copy link
Author

markchristopherng commented Jun 1, 2020

Hi just a little bit more information the affected classes seem to extend EpoxyModelWithView

E.g.

@EpoxyModelClass
abstract class EpoxyArticles : EpoxyModelWithView() {

@elihart
Copy link
Contributor

elihart commented Jun 1, 2020

thanks for the report. i will get a fix into the next beta release. very helpful to know this happens with EpoxyModelWithView :)

@elihart
Copy link
Contributor

elihart commented Jun 1, 2020

Fixed with #991. a 4.0.0-beta4 will be out later today that includes the fix

@elihart elihart closed this as completed Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants