Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate layout method #991

Merged
merged 2 commits into from
Jul 6, 2020
Merged

Fix duplicate layout method #991

merged 2 commits into from
Jul 6, 2020

Conversation

elihart
Copy link
Contributor

@elihart elihart commented Jun 1, 2020

Fixes #988

Also updates AGP to 4.0.

Got rid of checkstyle as something broke with it and the AGP upgrade. couldn't be bothered to figure out the fix since all our new code should be kotlin anyway

@lizhuogui
Copy link

Same issuse when override layout without annotation or different params name

    override fun layout(layoutRes: Int): EpoxyModel<TextView> {
        return super.layout(layoutRes)
    }
    override fun layout(@LayoutRes layout: Int): EpoxyModel<TextView> {
        return super.layout(layout)
    }

@elihart
Copy link
Contributor Author

elihart commented Jun 4, 2020

I've updated it to ignore param name and just look at type. annotation shouldn't affect it

@elihart elihart merged commit 435c2fb into master Jul 6, 2020
@elihart elihart deleted the eli-layout_duplicat_fail branch July 6, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.0.0.beta1 generating duplicate method layout(int)
2 participants