Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#99 Correct varargs parameters #100

Merged
merged 2 commits into from
Jan 27, 2017
Merged

#99 Correct varargs parameters #100

merged 2 commits into from
Jan 27, 2017

Conversation

geralt-encore
Copy link
Contributor

#99

@geralt-encore
Copy link
Contributor Author

Weird... 🤔
Tests are running successfully for me locally both from Android Studio and command line.

@elihart
Copy link
Contributor

elihart commented Jan 27, 2017

You're fast!

In the tests I see one file named ModelReturningClassTypeWithVarargs.java (notice the lower case args) and the generated filed is ModelReturningClassTypeWithVarArgs_.java with an uppercase Args. I think that's it?

elihart
elihart approved these changes Jan 27, 2017
View reviewed changes
Copy link
Contributor

@elihart elihart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once the test is passing. Thanks!

@geralt-encore
Copy link
Contributor Author

Looks like you were right. Not sure why did it work in a first place.

@elihart elihart merged commit 6936b36 into airbnb:master Jan 27, 2017
@elihart elihart mentioned this pull request Jan 27, 2017
Closed
@geralt-encore geralt-encore deleted the varargs branch January 28, 2017 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elihart elihart elihart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geralt-encore @elihart