Set packageid to com.airbnb.epoxy.viewbinder #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmecho
approved these changes
Apr 20, 2021
pmecho
added a commit
that referenced
this pull request
May 8, 2021
* Initial addition of view binder classes * Hook up visibility tracking Add view binder to kotlin sample * EpoxyViewBinder update - add epoxyView / optionalEpoxyView to ViewGroup (#1165) * Add epoxyView shortcut to ViewGroup * Add optionalEpoxyView for activity and view (with a minor refactor for less copy/paste) * switch to `androidx.core.app.ComponentActivity` Co-authored-by: Emmanuel Boudrant <eboudrant@netflix.com> * [View Binder] Add visibility tracker tests and API tweaks (#1168) * Add view binder visibility tests * Add basic unit tests for the view binder * Gradle clean up * Can't use ComponentActivity directly with the current dependency version Co-authored-by: Peter Elliott <peter.elliott@airbnb.com> * Set packageid to com.airbnb.epoxy.viewbinder (#1172) * package="com.airbnb.epoxy.viewbinder" * import com.airbnb.epoxy.viewbinder.R * Doc cleanup and refactors for line length * Move some extension functions to new file Some documentation tweaks * Add tests Add try/catch and fix up dependencies * Fix dependency mismatch Add newline * Add model update test * Apply suggestions from code review Co-authored-by: Eli Hart <eli.hart@airbnb.com> * Convert to ModelCollector Add exception handler Misc improvements based on PR comments * Fix comment and lint failures * Don't use debugImplementation as CI runs release tests * Fix tests due to model collector swap Co-authored-by: Peter Elliott <peter.elliott@airbnb.com> Co-authored-by: Emmanuel Boudrant <emmanuel.boudrant@gmail.com> Co-authored-by: Emmanuel Boudrant <eboudrant@netflix.com> Co-authored-by: Eli Hart <eli.hart@airbnb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pmecho, minor update for the package id in the new module