Fix click listener kapt bug #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elihart
force-pushed
the
eli-fix_click_listener_problem
branch
from
f4514c3 to
2ad48dd
Compare
vinaygaba
reviewed
Nov 15, 2022
|
|
||
|
|
||
| // https://vanniktech.github.io/gradle-maven-publish-plugin/other/ | ||
| publishing { |
There was a problem hiding this comment.
Thank you for this file, I ended up using this for Showkase publishing as well 🙏
vinaygaba
reviewed
Nov 15, 2022
| nonNullType == memoizer.viewOnClickListenerType -> ViewClickListener | ||
| nonNullType == memoizer.viewOnLongClickListenerType -> ViewLongClickListener | ||
| nonNullType == memoizer.viewOnCheckChangedType -> ViewCheckedChangeListener | ||
| // Note, == does not work for type comparisons when comparing types between classpath |
There was a problem hiding this comment.
any chance you could maybe describe the bug a bit more in the PR description. Just helps me understand a bit better. I can follow that the equals check wasn't what was needed but didn't understand what the difference in the generated code looked like
There was a problem hiding this comment.
is there any test case that could be added?
There was a problem hiding this comment.
hard to test because this happens when they are in different modules
vinaygaba
approved these changes
Nov 15, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a rare bug because of the xprocessing behavior change in its new version. In kapt only (not ksp), a click listener in a base epoxy model view class that has a sub class epoxy model view extend it specifically in a different module, would result in the sub class's generated epoxy model not having the OnModelClickListener override function. This is because the type checking for a click listener wasn't working correctly in this case where the click listener type was being inherited from a type on the class path. Was a simple fix to use correct type checking instead of ==
Also cleans up how publishing is done