Support onBind/onUnbind listeners on generated models #140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated models now include
onBind
andonUnbind
builder style method that takes a callback listener. When the model hits these lifecycle events the listener will be called with the model and view that was bound.This looks like
The goal is to avoid having one adapter method for handling onModelBound, and instead keeping the logic where the model is created.
This involved quite a bit change to the processor to generate the correct interface, store the listener fields, update hashCode/equals, etc. Also had to update all the tests.
Since I was updating all the tests and figuring out a good way to do this, I realized a better way to do the model click listener handling as well without storing the viewholder and bound object on the model. This seems cleaner and safer.