Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generated ModelViewModel_ OnModelClickListener Setter's Annotations #458

Merged

Conversation

baoti
Copy link
Contributor

@baoti baoti commented Jun 26, 2018

Fix wrong setter method annotation for model builder.

Now, the @Nullable annotation on the method:

@Nullable
public TestCallbackPropViewModel_ listener(final OnModelClickListener<TestCallbackPropViewModel_, TestCallbackPropView> listener) {
  // ...
  return this;
}

The PR fix it to annotation on the parameter:

public TestCallbackPropViewModel_ listener(@Nullable final OnModelClickListener<TestCallbackPropViewModel_, TestCallbackPropView> listener) {
  // ...
  return this;
}

@baoti
Copy link
Contributor Author

baoti commented Jul 4, 2018

@elihart I make this change move @Nullable to OnModelClickListener parameter.

@elihart
Copy link
Contributor

elihart commented Jul 4, 2018

Thanks, I'll try to look soon

Copy link
Contributor

@elihart elihart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baoti This is great! thanks a lot for the fix, and I apologize for the long delay in reviewing

@baoti
Copy link
Contributor Author

baoti commented Jul 25, 2018

That doesn't matter. Thanks! 😃

@elihart elihart merged commit b55e2e0 into airbnb:master Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants