Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements visibility events for EpoxyRecyclerView/EpoxyViewHolder. #560
Implements visibility events for EpoxyRecyclerView/EpoxyViewHolder. #560
Changes from all commits
ef42810
a0fe6a4
03fc799
5b175d2
3b29fe8
33757a9
7727d1f
625b76d
a080b51
51fb99f
16d71f6
62478ba
aa39ae2
cd5619f
25ce009
c3f5e2e
b1bcc9f
22d5126
4f2e2eb
38267bb
85fa891
a965ab1
f96ce25
ecc85c2
f3f4440
0f81812
323dc69
2d26aaf
f54178c
e780c0a
e2d675e
b3b40d3
0ca9771
ad083de
7a1b97e
7db96a9
e150b9d
bae5693
4eda5c9
44ed7e5
d042c68
e975337
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edit: i realized that
fullyVisible
is tracked so we don't notify the event twice (at least that is my understanding) - maybe that could be renamed tohasNotifiedFullyVisible
?additionally it seems more clear and safer to set this field explicitly where we do the notify call
original:
fullyVisible
is also set inisFullImpressionVisible
. seems it should be only set in one placeeven better,
isFullImpressionVisible
seems to be derived only fromvisibleSize != sizeInScrollingDirection
which are also stored in fields, instead of storing data derived from that that could get out of sync can we just do this?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not ideal that what would appear to be a simple getter has the side effect of updating the
visible
field. maybe this method can be named to reflect that?alternatively I feel that tracking both
visible
andvisibleSize
could be redundant - what if we could deriveisVisible()
purely fromvisibleSize
? -1 or null could represent detached.I see that
update
already setsvisibleSize
to 0 if detachEvent is true, so the logic in this method feels unnecessarySame thoughts apply to
isUnfocusedVisible