Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preloader system with glide extensions #766

Merged
merged 4 commits into from
Jun 18, 2019
Merged

Preloader system with glide extensions #766

merged 4 commits into from
Jun 18, 2019

Conversation

elihart
Copy link
Contributor

@elihart elihart commented Jun 14, 2019

Updated version of #593

This creates a generic preloading system, with integration into EpoxyRecyclerView.

It also adds an optional module for easy prefetching with glide.

Usage is as simple as

recycler_view.addGlidePreloader(
            Glide.with(this),
            preloader = glidePreloader { requestManager, model: ImageModel_, _ ->
                requestManager.loadImage(model.imageUrl)
            }
        )

Once this is merged I'll push a new release with it and add a usage guide to the wiki.

If anyone is interested in adding support for other image libraries, like Picasso, feel free to open a PR and copy the glide implementation here. It is pretty straightforward.

@elihart
Copy link
Contributor Author

elihart commented Jun 17, 2019

There is an issue where running the annotation processor in tests fails fails to properly compile because of issues with the new kotlin code in epoxy-adapter. Can't merge until that is figured out

@elihart elihart merged commit a5620f9 into master Jun 18, 2019
@elihart elihart deleted the KirkBushman-master branch June 18, 2019 01:49
@elihart elihart mentioned this pull request Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant