Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite loadBefore calls #817

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix infinite loadBefore calls #817

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions epoxy-paging/src/main/java/com/airbnb/epoxy/paging/PagedListModelCache.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,11 @@ internal class PagedListModelCache<T>(
(0 until count).forEach {
modelCache.add(position, null)
}
lastPosition?.let {
if (position < it) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if it + count is greater than position? you compare these two but don't look at the value of count

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does it matter if it + count is greater than position?
If lastPosition was 5 and we just inserted 50 items before 5th position e.g. onInserted(position = 0, count = 50) then your "lastPosition" MUST be adjusted to 50 + 5.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lastPosition is the last index that was bound, not the last index that was added. They are too different things, and using the same property to represent two different things is confusing and dangerous.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lastPosition can be renamed to nextLoadAroundPosition. When we insert new data in the list before this position, this variable no longer holds true. so renaming it may help. This way nextLoadAroundPosition acts like a command argument that should be used in next call to loadAround. This is exactly how it is being used now btw.

lastPosition = it + count
}
}
rebuildCallback()
}

Expand Down