Carousel - Use measured width/height if it exists.

[ekimmel-ta]

My carousel component is not full width. The current carousel implementation was defaulting to the full screen width because layout had not completed yet.

This PR adds measured width / measured height to the getTotalWidthPx and getTotalHeightPx functions in Carousel to help prevent a situation where the carousel is not using the intending width.

[elihart]

Sounds good to me :)

[andybdahl]

This merge created the issue mentioned in the issue #682 . A proper layout should be done by only using the view's width / measured height as long as the orientation stays the same, and should default to the screen width OR measure the Carousel once again after configuration changes has been made.

[elihart]

@andybdahl thanks for catching this. are you interested in contributing that fix?

[andybdahl]

@elihart We fixed it locally in our app already, I'll be putting up a merge request when I get the time for it soon.

…

On Thu, 11 Feb 2021, 17.10 Eli Hart, ***@***.***> wrote: @andybdahl <https://github.com/andybdahl> thanks for catching this. are you interested in contributing that fix? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#915 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHDZZOWZGGWDGOJ4UUMQVBTS6P6Q3ANCNFSM4KP4WTIA> .

[ekimmel-ta]

Hi, could you explain how this PR affects your issue? Epoxy was already using this.width previously, and as you said that value is wrong during configuration changes.

I did find that Epoxy reusing a Carousel model with a different width, even without configuration changes, is still broken. Width is the old value and measuredWidth is the correct, updated value. I don't know how we could detect that width is out of date.

[ekimmel-ta]

Slight update: Using width before measuredWidth is incorrect if this function is called during onMeasure (meaning during onChildAttachedToWindow as well). I don't know if that means we should be using measuredWidth only or if we need to flag when we're in the measurement phase.