Configurable JVM options for Mesos executor #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code here (not yours, the existing code) is misleading, and unfortunately this change will not have any effect. The TT takes the JVM opts from the I spent a while trying to make this work the way you'd think it should work, but I had little success. |
|
Disregard my previous comment after our brief conversion. 👍 |
|
Also, would you mind closing this PR and submitting it to the official repo at https://github.com/mesos/hadoop instead? |
This was referenced Jan 8, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JVM options are currently hardcoded - it would be nice to be able to configure them via a new conf key
mapred.mesos.executor.jvm.opts. The diff retains the previous JVM settings as defaults if the key/val is not set.@brndnmtthws