Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider disabling react/no-unused-prop-types #1099

Closed
billyjanitsch opened this issue Sep 30, 2016 · 1 comment
Closed

Consider disabling react/no-unused-prop-types #1099

billyjanitsch opened this issue Sep 30, 2016 · 1 comment
Labels
semver-patch: loosen/fix/document rules

Comments

@billyjanitsch
Copy link
Contributor

The react/no-unused-prop-types rule is currently quite buggy. In combination with the recently-enabled (here) react/forbid-prop-types, it makes writing propTypes for objects tricky.

For example, since PropTypes.object is forbidden, there's no way to get around jsx-eslint/eslint-plugin-react#833 (using PropTypes.shape) without disabling one of the two rules.

Would you consider disabling the rule until its kinks are ironed out?
@ljharb
Copy link
Collaborator

ljharb commented Sep 30, 2016

That does seem reasonable - there have been quite a lot of bugs around that rule.

@einarlove einarlove mentioned this issue Oct 21, 2016
Merged
@ljharb ljharb closed this as completed in a06831d Oct 22, 2016
hibearpanda pushed a commit to 15Prospects/javascript that referenced this issue Jan 22, 2017
@ljharb @hibearpanda
[eslint config] [patch] set react/no-unused-prop-types to “warn”, p…
d0eccf3 
…ending bugfixes.

Closes airbnb#1099.
jaylaw81 pushed a commit to appirio-digital/ads-best-practices that referenced this issue Sep 19, 2017
@ljharb @jaylaw81
[eslint config] [patch] set react/no-unused-prop-types to “warn”, p…
ddb3076 
…ending bugfixes.

Closes airbnb#1099.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
semver-patch: loosen/fix/document rules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ljharb @billyjanitsch