Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imports rules: add eslint flat config support #2818

Closed
wants to merge 8 commits into from
Closed

Imports rules: add eslint flat config support #2818

wants to merge 8 commits into from

Conversation

OlivierZal
Copy link

No description provided.

@ljharb
Copy link
Collaborator

ljharb commented Aug 24, 2023

This change is fine, but it doesn't actually add flat config support, it just adds a default for a flat config config file.

@ljharb
Copy link
Collaborator

ljharb commented Aug 24, 2023

Is the only way to support that a new entrypoint? if so, then a /flat entrypoint in both configs seems fine with me.

packages/eslint-config-airbnb-base/flat.js Outdated Show resolved Hide resolved
packages/eslint-config-airbnb-base/flat.js Show resolved Hide resolved
packages/eslint-config-airbnb-base/flat.js Outdated Show resolved Hide resolved
packages/eslint-config-airbnb-base/flat.js Outdated Show resolved Hide resolved
@OlivierZal OlivierZal requested a review from ljharb August 31, 2023 22:08
Co-authored-by: Jordan Harband <ljharb@gmail.com>
@ljharb
Copy link
Collaborator

ljharb commented Aug 31, 2023

This looks good - obv it's blocked on the import plugin supporting flat config.

@ljharb ljharb marked this pull request as draft August 31, 2023 22:40
@OlivierZal OlivierZal closed this Sep 2, 2023
@OlivierZal OlivierZal deleted the olivierzal/imports_rules/eslint_flat_config_support branch September 2, 2023 11:55
@ljharb
Copy link
Collaborator

ljharb commented Sep 2, 2023

Why did you delete your fork, making this PR unrecoverable??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants