Cache compositions loaded by url in memory (#1657)

Fixes #1648
airbnb · Oct 24, 2020 · 19cf3f0 · 19cf3f0
1 parent b27f6d3
commit 19cf3f0
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/lottie/src/main/java/com/airbnb/lottie/LottieCompositionFactory.java b/lottie/src/main/java/com/airbnb/lottie/LottieCompositionFactory.java
@@ -86,7 +86,11 @@ public static LottieTask<LottieComposition> fromUrl(final Context context, final
     return cache(cacheKey, new Callable<LottieResult<LottieComposition>>() {
       @Override
       public LottieResult<LottieComposition> call() {
-        return L.networkFetcher(context).fetchSync(url, cacheKey);
+        LottieResult<LottieComposition> result = L.networkFetcher(context).fetchSync(url, cacheKey);
+        if (cacheKey != null && result.getValue() != null) {
+          LottieCompositionCache.getInstance().put(cacheKey, result.getValue());
+        }
+        return result;
       }
     });
   }
@@ -109,7 +113,11 @@ public static LottieResult<LottieComposition> fromUrlSync(Context context, Strin
    */
   @WorkerThread
   public static LottieResult<LottieComposition> fromUrlSync(Context context, String url, @Nullable String cacheKey) {
-    return L.networkFetcher(context).fetchSync(url, cacheKey);
+    LottieResult<LottieComposition> result = L.networkFetcher(context).fetchSync(url, cacheKey);
+    if (cacheKey != null && result.getValue() != null) {
+      LottieCompositionCache.getInstance().put(cacheKey, result.getValue());
+    }
+    return result;
   }
 
   /**