Prevent duplicate positions in gradient fills (#1768)

Fixes #1675
airbnb · Mar 22, 2021 · 8ed9569 · 8ed9569
1 parent 4deb885
commit 8ed9569
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/.gitignore b/.gitignore
@@ -22,6 +22,7 @@
 .idea/**/dynamic.xml
 .idea/**/uiDesigner.xml
 .idea/**/dbnavigator.xml
+.idea/deploymentTargetDropDown.xml
 
 # Gradle
 .idea/**/gradle.xml

diff --git a/.idea/inspectionProfiles/Project_Default.xml b/.idea/inspectionProfiles/Project_Default.xml
diff --git a/lottie/src/main/java/com/airbnb/lottie/parser/GradientColorParser.java b/lottie/src/main/java/com/airbnb/lottie/parser/GradientColorParser.java
@@ -72,8 +72,13 @@ public GradientColor parse(JsonReader reader, float scale)
       double value = array.get(i);
       switch (i % 4) {
         case 0:
-          // position
-          positions[colorIndex] = (float) value;
+          // Positions should monotonically increase. If they don't, it can cause rendering problems on some phones.
+          // https://github.com/airbnb/lottie-android/issues/1675
+          if (colorIndex > 0 && positions[colorIndex - 1] >= (float) value) {
+            positions[colorIndex] = (float) value + 0.01f;
+          } else {
+            positions[colorIndex] = (float) value;
+          }
           break;
         case 1:
           r = (int) (value * 255);