Removed some unused code (#1942)

lottie/src/main/java/com/airbnb/lottie/LottieComposition.java

@@ -4,6 +4,7 @@
 import android.content.res.Resources;
 import android.graphics.Rect;
 
+import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 import androidx.annotation.RawRes;
 import androidx.annotation.RestrictTo;
@@ -217,7 +218,9 @@ public float getDurationFrames() {
   }
 
 
-  @Override public String toString() {
+  @NonNull
+  @Override
+  public String toString() {
     final StringBuilder sb = new StringBuilder("LottieComposition:\n");
     for (Layer layer : layers) {
       sb.append(layer.toString("\t"));
@@ -334,6 +337,7 @@ public static LottieComposition fromInputStreamSync(InputStream stream, boolean
     @WorkerThread
     @Deprecated
     public static LottieComposition fromJsonSync(@SuppressWarnings("unused") Resources res, JSONObject json) {
+      //noinspection deprecation
       return LottieCompositionFactory.fromJsonSync(json, null).getValue();
     }
 
@@ -378,4 +382,4 @@ private ListenerAdapter(OnCompositionLoadedListener listener) {
       }
     }
   }
-}
+}

lottie/src/main/java/com/airbnb/lottie/model/FontCharacter.java

@@ -40,18 +40,10 @@ public List<ShapeGroup> getShapes() {
     return shapes;
   }
 
-  double getSize() {
-    return size;
-  }
-
   public double getWidth() {
     return width;
   }
 
-  String getStyle() {
-    return style;
-  }
-
   @Override public int hashCode() {
     return hashFor(character, fontFamily, style);
   }

lottie/src/main/java/com/airbnb/lottie/model/animatable/AnimatableFloatValue.java

@@ -8,10 +8,6 @@
 
 public class AnimatableFloatValue extends BaseAnimatableValue<Float, Float> {
 
-  AnimatableFloatValue() {
-    super(0f);
-  }
-
   public AnimatableFloatValue(List<Keyframe<Float>> keyframes) {
     super(keyframes);
   }

lottie/src/main/java/com/airbnb/lottie/model/animatable/AnimatableIntegerValue.java

@@ -8,10 +8,6 @@
 
 public class AnimatableIntegerValue extends BaseAnimatableValue<Integer, Integer> {
 
-  public AnimatableIntegerValue() {
-    super(100);
-  }
-
   public AnimatableIntegerValue(List<Keyframe<Integer>> keyframes) {
     super(keyframes);
   }

lottie/src/main/java/com/airbnb/lottie/model/animatable/AnimatablePathValue.java

@@ -7,19 +7,11 @@
 import com.airbnb.lottie.animation.keyframe.PointKeyframeAnimation;
 import com.airbnb.lottie.value.Keyframe;
 
-import java.util.Collections;
 import java.util.List;
 
 public class AnimatablePathValue implements AnimatableValue<PointF, PointF> {
   private final List<Keyframe<PointF>> keyframes;
 
-  /**
-   * Create a default static animatable path.
-   */
-  public AnimatablePathValue() {
-    keyframes = Collections.singletonList(new Keyframe<>(new PointF(0, 0)));
-  }
-
   public AnimatablePathValue(List<Keyframe<PointF>> keyframes) {
     this.keyframes = keyframes;
   }

lottie/src/main/java/com/airbnb/lottie/model/animatable/AnimatableScaleValue.java

@@ -9,10 +9,6 @@
 
 public class AnimatableScaleValue extends BaseAnimatableValue<ScaleXY, ScaleXY> {
 
-  AnimatableScaleValue() {
-    this(new ScaleXY(1f, 1f));
-  }
-
   public AnimatableScaleValue(ScaleXY value) {
     super(value);
   }

lottie/src/main/java/com/airbnb/lottie/model/content/GradientFill.java

@@ -71,14 +71,6 @@ public AnimatablePointValue getEndPoint() {
     return endPoint;
   }
 
-  @Nullable AnimatableFloatValue getHighlightLength() {
-    return highlightLength;
-  }
-
-  @Nullable AnimatableFloatValue getHighlightAngle() {
-    return highlightAngle;
-  }
-
   public boolean isHidden() {
     return hidden;
   }

lottie/src/main/java/com/airbnb/lottie/network/DefaultLottieFetchResult.java

@@ -59,8 +59,6 @@ private String getErrorFromConnection(HttpURLConnection connection) throws IOExc
       while ((line = r.readLine()) != null) {
         error.append(line).append('\n');
       }
-    } catch (Exception e) {
-      throw e;
     } finally {
       try {
         r.close();

lottie/src/main/java/com/airbnb/lottie/network/FileExtension.java

@@ -23,14 +23,4 @@ public String tempExtension() {
     return extension;
   }
 
-  public static FileExtension forFile(String filename) {
-    for (FileExtension e : values()) {
-      if (filename.endsWith(e.extension)) {
-        return e;
-      }
-    }
-    // Default to Json.
-    Logger.warning("Unable to find correct extension for " + filename);
-    return JSON;
-  }
 }

lottie/src/main/java/com/airbnb/lottie/utils/Utils.java

@@ -309,6 +309,7 @@ public static void saveLayerCompat(Canvas canvas, RectF rect, Paint paint, int f
   /**
    * For testing purposes only. DO NOT USE IN PRODUCTION.
    */
+  @SuppressWarnings("unused")
   public static Bitmap renderPath(Path path) {
     RectF bounds = new RectF();
     path.computeBounds(bounds, false);

lottie/src/test/java/com/airbnb/lottie/LottieCompositionFactoryTest.java

@@ -13,14 +13,12 @@
 import java.io.InputStream;
 
 import static junit.framework.Assert.assertEquals;
-import static junit.framework.Assert.assertFalse;
 import static junit.framework.Assert.assertNotNull;
 import static junit.framework.Assert.assertNotSame;
 import static junit.framework.Assert.assertNull;
 import static okio.Okio.buffer;
 import static okio.Okio.source;
 import static org.junit.Assert.assertSame;
-import static org.junit.Assert.assertTrue;
 
 @SuppressWarnings("ReferenceEquality")
 public class LottieCompositionFactoryTest extends BaseTest {
@@ -120,7 +118,6 @@ public void testZeroCacheWorks() {
         JsonReader reader = JsonReader.of(buffer(source(getNeverCompletingInputStream())));
         LottieCompositionFactory.setMaxCacheSize(1);
         LottieResult<LottieComposition> taskFoo1 = LottieCompositionFactory.fromJsonReaderSync(reader, "foo");
-        LottieResult<LottieComposition> taskBar = LottieCompositionFactory.fromJsonReaderSync(reader, "bar");
         LottieResult<LottieComposition> taskFoo2 = LottieCompositionFactory.fromJsonReaderSync(reader, "foo");
         assertNotSame(taskFoo1, taskFoo2);
     }

lottie/src/test/java/com/airbnb/lottie/LottieTaskTest.java

@@ -25,11 +25,7 @@ public void setup() {
 
   @Test
   public void testListener() {
-    LottieTask<Integer> task = new LottieTask<>(new Callable<LottieResult<Integer>>() {
-      @Override public LottieResult<Integer> call() {
-        return new LottieResult<>(5);
-      }
-    }, true)
+    new LottieTask<>(() -> new LottieResult<>(5), true)
         .addListener(successListener)
         .addFailureListener(failureListener);
     verify(successListener, times(1)).onResult(5);
@@ -39,10 +35,8 @@ public void testListener() {
   @Test
   public void testException() {
     final IllegalStateException exception = new IllegalStateException("foo");
-    LottieTask<Integer> task = new LottieTask<>(new Callable<LottieResult<Integer>>() {
-      @Override public LottieResult<Integer> call() {
-        throw exception;
-      }
+    new LottieTask<>((Callable<LottieResult<Integer>>) () -> {
+      throw exception;
     }, true)
         .addListener(successListener)
         .addFailureListener(failureListener);

snapshot-tests/src/androidTest/java/com/airbnb/lottie/snapshots/utils/HappoSnapshotter.kt

@@ -102,10 +102,14 @@ class HappoSnapshotter(
         val json = JsonObject()
         val snaps = JsonArray()
         json.add("snaps", snaps)
-        snapshots.forEach {
-            snaps.add(it.toJson())
+        snapshots.forEach { s ->
+            snaps.add(s.toJson())
+        }
+        Log.d(L.TAG, "Finished creating snapshot report")
+        reportNames.forEach { reportName ->
+        Log.d(L.TAG, "Uploading $reportName")
+            upload(reportName, json)
         }
-        reportNames.forEach { upload(it, json) }
     }
 
     private suspend fun upload(reportName: String, json: JsonElement) {