[Compose] Upgrade to Alpha 11 #1732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jossiwolf
commented
Jan 29, 2021
| onCommit(applyOpacityToLayers.value) { | ||
| animationState.applyOpacityToLayers = applyOpacityToLayers.value | ||
| } | ||
| animationState.outlineMasksAndMattes = outlineMasksAndMattes.value |
There was a problem hiding this comment.
I am not exactly sure about this one - I don't think the onCommit was needed. Let me know what you think! Maybe this should actually be a SideEffect?
gpeal
reviewed
Jan 29, 2021
sample-compose/src/main/java/com/airbnb/lottie/sample/compose/lottiefiles/LottieFilesPage.kt
Outdated
Show resolved
Hide resolved
jossiwolf
force-pushed
the
jwolf/compose-alpha11
branch
from
56ec0f5 to
068b402
Compare
gpeal
approved these changes
Jan 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades Compose to Alpha 11!
I migrated some deprecated APIs, mostly related to effects. Also wrapped the player controls and toolbar in the
AnimatedVisibilitycomposable so toggling focus mode feels a little less jumpy.Did some manual testing and everything looks good in the sample app 🎉
Let me know what you think about the content descriptions for icons - I'll be happy to add some, but you tell me if it's needed!