Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary compatibility with 6.5 and lower on LottieAnimation #2591

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

inorichi
Copy link
Contributor

@inorichi inorichi commented Dec 9, 2024

After #2548 was merged, the binary compatibility of the LottieAnimation composable changed, making it incompatible with previous versions. This PR fixes that.

Motivation: our team has a multi-repo approach and some colleagues did not update lottie for some reasons and we need to synchronize the update. With this PR we should not need to do that.

Fixes #2568

@gpeal
Copy link
Collaborator

gpeal commented Dec 15, 2024

Unfortunately, this makes LottieAnimation appear as deprecated for everybody unless they use the new parameter.

This is an issue I'm aware but but don't know of any good solutions. This one won't work though, unfortuatenly.

Can you think of any others?

image

@inorichi inorichi force-pushed the bug/binary-compatibility branch from b5521d9 to 7c291a2 Compare December 15, 2024 06:01
@inorichi
Copy link
Contributor Author

Can you check again? It shouldn't show up with the hidden deprecation level.

By the way, I only added compatibility to the first composable of the file, which is the method we're using. The second one is already deprecated so maybe it doesn't make sense to support it, but I'm not sure about the last one 🤔 .

@inorichi inorichi force-pushed the bug/binary-compatibility branch from 7c291a2 to cc912dc Compare December 15, 2024 06:12
@gpeal
Copy link
Collaborator

gpeal commented Dec 15, 2024

Can you check again? It shouldn't show up with the hidden deprecation level.

By the way, I only added compatibility to the first composable of the file, which is the method we're using. The second one is already deprecated so maybe it doesn't make sense to support it, but I'm not sure about the last one 🤔 .

Seems to be okay! Thanks for the update

Copy link

Snapshot Tests
API 23: Report Diff
API 31: Report Diff

@gpeal gpeal merged commit 43deff5 into airbnb:master Dec 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Library update from 6.5.2 to 6.6.0 cause crash
2 participants