Add additional dynamic library product to Package.swift #2507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calda
reviewed
Dec 5, 2024
| products: [.library(name: "Lottie", targets: ["Lottie"])], | ||
| products: [ | ||
| .library(name: "Lottie", targets: ["Lottie"]), | ||
| .library(name: "Lottie-Dynamic", type: .dynamic, targets: ["Lottie"]), |
There was a problem hiding this comment.
Can you add a comment here explaining the difference between Lottie and Lottie-Dynamic, and a quick explanation of when you would prefer to use Lottie-Dynamic instead of Lottie?
There was a problem hiding this comment.
Hi @calda , thank you for your quick response! I've added a short description to the Package.swift hope this is sufficient.
|
Hey! This is precisely what we need. P.S. |
roman-suvorov-onseo
pushed a commit
to roman-suvorov-onseo/lottie-ios
that referenced
this pull request
Dec 26, 2024
roman-suvorov-onseo
added a commit
to roman-suvorov-onseo/lottie-ios
that referenced
this pull request
Dec 26, 2024
|
Sure, I just released 4.5.1: https://github.com/airbnb/lottie-ios/releases/tag/4.5.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Lottie-Team,
I would like to link the Lottie framework dynamically to use it inside another framework.
To avoid duplicate symbols the library should not embedded in the framework target and only embedded in the app target.
To solve this issue (since SPM Dependencies are automatically built statically) another product has been added to the
Package.swiftfile allowing to build a dynamic framework. This seems to be a common practice as it is used by the SnapKit and RxSwift framework.