Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require debug flag #196

Merged
merged 4 commits into from
Feb 17, 2019
Merged

Require debug flag #196

merged 4 commits into from
Feb 17, 2019

Conversation

marukami
Copy link
Contributor

Updated BaseMvRxViewModel to now require the debug flag #190

Had to fix formatting reported by Detekt before was able to push with git hooks enabled.

Update Readme.me with

  • To have the most recent release version
  • Added debug flag using BuildConfig as a base guideline.

@gpeal
Copy link
Collaborator

gpeal commented Feb 17, 2019

@marukami Thanks! Can you add something to the changelog indicating that this may be a breaking change if you weren't already using debug mode?

gpeal
gpeal approved these changes Feb 17, 2019
View reviewed changes
Copy link
Collaborator

@gpeal gpeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gpeal gpeal merged commit 27de2fd into airbnb:master Feb 17, 2019
@marukami marukami deleted the require-debug-flag branch December 15, 2019 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpeal gpeal gpeal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marukami @gpeal