Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date example to work with IOS #236

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix date example to work with IOS #236

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3b04d6
Fix date example to work with IOS
mmarkelov Aug 3, 2019
d15a19a
Fix date constructor
mmarkelov Aug 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stories/ExampleSlider.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,8 @@ storiesOf('Slider', module)
);
})
.add('Dates', () => {
const startDate = new Date('01-01-2015').valueOf();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also broken in Safari; another alternative is using slashes instead of dashes - maybe we should go with that?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ljharb I just fix date constructor (I forgot that dates start from 0), and seems like it's ok now:
safari

const endDate = new Date('12-31-2015').valueOf();
const startDate = new Date(2015, 0, 1).valueOf();
const endDate = new Date(2015, 11, 31).valueOf();
const months = ['Jan', 'Feb', 'Mar', 'Apr', 'May', 'Jun', 'Jul', 'Aug', 'Sep', 'Oct', 'Nov', 'Dec'];

function ordinal(n) {
Expand Down