Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Update to include latest Santa rule types of TeamID and SigningID support #44

Merged
merged 4 commits into from
Mar 30, 2024

Conversation

radsec
Copy link
Contributor

@radsec radsec commented Mar 29, 2024

to: @MarkVLK @natesinger @Tejunalwad
cc: @airbnb/rudolph-maintainers

Background

Follow up to this PR: #41 to include syncing for these new rule types now.

Changes

  • Update sync/DDB schema upgrades to support TeamID and SigningID rule types
  • Maintain backwards compatibility with prior SHA256 references for priorly created rules
  • Update CLI tooling and included examples

Testing

Internal development and next version sync servers.

TeamID Rule testing:
Screenshot 2024-03-29 at 17 20 02

SigningID Rule testing:
Screenshot 2024-03-29 at 17 59 37

@radsec radsec force-pushed the rad/add-support-new-rule-types branch from 9cf01a2 to 54b9679 Compare March 30, 2024 01:22
@radsec radsec force-pushed the rad/add-support-new-rule-types branch from 54b9679 to 213c74a Compare March 30, 2024 01:28
Copy link

@MarkVLK MarkVLK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radsec radsec merged commit 7c425c1 into airbnb:master Mar 30, 2024
@radsec radsec deleted the rad/add-support-new-rule-types branch March 30, 2024 16:49
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants