Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Update FeedRules logic to factor in TeamID and SigningID rules + validation checks #48

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

radsec
Copy link
Contributor

@radsec radsec commented Apr 4, 2024

to: @MarkVLK
cc: @airbnb/rudolph-maintainers

Background

Update FeedRules logic to factor in TeamID and SigningID rules + validation checks. Since the new rules, not every rule contains a SHA256 or checksum identifier. Rules now contain random identifiers as such so validation checks should be added for each of these new rule types.

Changes

  • Update FeedRules logic to factor in TeamID and SigningID rules
  • While the current engine can handle this, it can be difficult to derive the state at which a machine is at when looking at a variety of FeedRules that contain teamID or signingID identifiers. This change makes it clear in the current DynamoDB insertion that Identifier field should be used
  • Add validation logic for the new rule types...this can be used in a variety of ways downstream or within the project itself

Testing

Deployed to internal development systems.

@radsec radsec requested a review from MarkVLK April 4, 2024 01:21
Copy link

@MarkVLK MarkVLK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radsec radsec merged commit 8ecc610 into airbnb:master Apr 4, 2024
@radsec radsec deleted the rad/update-feed-rules-and-validation branch April 4, 2024 02:53
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants