Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Resolve some issues with RuleFeeds and Rule Downloads not working with latest TeamIDs and SigningIDs #49

Merged
merged 4 commits into from
Apr 5, 2024

Conversation

radsec
Copy link
Contributor

@radsec radsec commented Apr 5, 2024

to: @natesinger @mike-flowers-airbnb
cc: @airbnb/rudolph-maintainers

Background

[Bug] Resolve some issues with RuleFeeds and Rule Downloads not working with latest TeamIDs and SigningIDs

Changes

  • Resolve some issues with DDB Queries not resolving newly added fields properly
  • Use the DDB expressions builder package to build the queries so its more verbose/easy to understand
  • Add some additional test coverage to assert the logic
  • Various code cleanup, legacy deps removal, and linting

Testing

Deployed internally on development/staging Santa instances.

Copy link

@mike-flowers-airbnb mike-flowers-airbnb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@radsec radsec merged commit f5ec879 into airbnb:master Apr 5, 2024
@radsec radsec deleted the rad/rule-downloads branch April 5, 2024 17:41
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants