[dev] fix redux devtools (apache#5855)

airbnb · Sep 11, 2018 · 1f6e8b3 · 1f6e8b3
1 parent 965c838
commit 1f6e8b3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/superset/assets/src/reduxUtils.js b/superset/assets/src/reduxUtils.js
@@ -70,7 +70,7 @@ export function addToArr(state, arrKey, obj, prepend = false) {
 
 export function initEnhancer(persist = true) {
   let enhancer = persist ? compose(persistState()) : compose();
-  if (process.env.NODE_ENV === 'dev') {
+  if (process.env.WEBPACK_MODE === 'development') {
     /* eslint-disable-next-line no-underscore-dangle */
     const composeEnhancers = window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__ || compose;
     enhancer = persist ? composeEnhancers(persistState()) : composeEnhancers();

diff --git a/superset/assets/webpack.config.js b/superset/assets/webpack.config.js
@@ -35,6 +35,11 @@ const plugins = [
 
   // create fresh dist/ upon build
   new CleanWebpackPlugin(['dist']),
+
+  // expose mode variable to other modules
+  new webpack.DefinePlugin({
+    'process.env.WEBPACK_MODE': JSON.stringify(mode),
+  }),
 ];
 
 if (isDevMode) {