This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Cherry-picks: Sunburst, Horizon, Treemap and a few small updates from community #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add geojson for Myanmar * Adds 'myanmar.geojson' file * Adds "iso-3166" codes (cherry picked from commit 0e057d5)
* Do not call slice.xxx * remove iframe id * remove old code * use import instead of require * update iframe.js (cherry picked from commit 9fb28b5)
* Add geojson for Myanmar * Adds 'myanmar.geojson' file * Adds "iso-3166" codes * Uppercase ISO fieldname in TL, MY geodata (cherry picked from commit 5e6efae)
* refactor treemap * refactor treemap code * Add proptypes * add proptypes for tree * Add margin prop (cherry picked from commit 54ae215)
(cherry picked from commit f5cc983)
* Migrate horizon chart to react * remove unused code * rename files * update props * enable renderTrigger * fix canvas transform issue * Address Chris' comment (cherry picked from commit d7f06cb)
* extract slice and formData * fix small issues * Update visual * update css (cherry picked from commit 8d01c84)
kristw
changed the title
kristw
requested review from
graceguo-supercat and
williaster
and removed request for
graceguo-supercat
Codecov Report
@@ Coverage Diff @@
## airbnb-master #101 +/- ##
=================================================
- Coverage 63.19% 63.18% -0.01%
=================================================
Files 351 352 +1
Lines 22055 22054 -1
Branches 2473 2470 -3
=================================================
- Hits 13937 13935 -2
- Misses 8106 8107 +1
Partials 12 12
Continue to review full report at Codecov.
|
michellethomas
approved these changes
Aug 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick the following commit(s):
Pass js unit test and verified on development box.
@john-bodley @conglei @graceguo-supercat @kristw @michellethomas @timifasubaa @williaster