Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Cherry-picks: Several bug fixes and react HMR #114

Merged
merged 8 commits into from
Sep 18, 2018
Merged

Cherry-picks: Several bug fixes and react HMR #114

merged 8 commits into from
Sep 18, 2018

Commits on Sep 18, 2018

  1. enable HMR + resolve conflict

    @kristw
    kristw committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    b0bc5fd View commit details
    Browse the repository at this point in the history

  2. [bugfix] 'No numeric types to aggregate' in NVD3 chart (apache#5853) 

    (cherry picked from commit 73cfccc)
    @mistercrunch @kristw
    mistercrunch authored and kristw committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    9019068 View commit details
    Browse the repository at this point in the history

  3. [bugfix] mapbox pan on filter (apache#5858) 

    * Pan mapbox map on query

- Modify the backend to send back the bounds of the points to cluster
- Clean up of mapbox component to derive lat, lon and zoom from the mercator that fitsbounds based on the bounds passed from the backend. This and the computation of clusters are now only done on initial load b/c we are not making queries to the backend on pan/zoom
- A minor clean up of unused props and also making the visual properties panel open by default

* Remove default latitude, longitude and zoom props which are unnecessary for computing the viewport now that it is driven by the bounds from the backend.

* a few small tweaks (rename vars to be sneak case and avoid two extra hash lookups)

(cherry picked from commit 6df720d)
    @xtinec @kristw
    xtinec authored and kristw committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    f3cb6ac View commit details
    Browse the repository at this point in the history

  4. resolve conflict

    @kristw
    kristw committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    5d829e1 View commit details
    Browse the repository at this point in the history

  5. [dev] fix redux devtools (apache#5855) 

    (cherry picked from commit 1f6e8b3)
    @williaster @kristw
    williaster authored and kristw committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    4edab8c View commit details
    Browse the repository at this point in the history

  6. Fix CSS theme flickering on FAB pages (apache#5880) 

    Since the recent PRs around webpack 4 and reloading, FAB pages have been
flickering on load, where a themeless Superset is shown for a fraction
of a second until the bootstrap theme gets loaded up.

This addresses it by moving the theme JS to the head section of the html
page.

(cherry picked from commit 80faa8d)
    @mistercrunch @kristw
    mistercrunch authored and kristw committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    789604e View commit details
    Browse the repository at this point in the history

  7. Remove jquery usage to highlight sql lab menu (apache#5907) 

    * Remove jquery hack

* change filter to find

(cherry picked from commit 39ef77a)
    @kristw
    kristw committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    1b769e2 View commit details
    Browse the repository at this point in the history

  8. [bugfix] Fix percent metric display and check for string columns in t… 

    …able (apache#5917)

* fix percent metric display

* add empty line

* address string or number check

(cherry picked from commit 19a3319)
    @kristw
    kristw committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    248a45d View commit details
    Browse the repository at this point in the history