Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Cherrypick more csv changes #117

Merged
merged 3 commits into from
Sep 20, 2018
Merged

Cherrypick more csv changes #117

merged 3 commits into from
Sep 20, 2018

Conversation

timifasubaa
Copy link

@timifasubaa timifasubaa commented Sep 20, 2018

This PR adds some more CSV changes

  1. It infers the column type in the CSV files ([hive-csv] Infer schema from csv apache/superset#5267)
  2. It quotes the column names (quote hive column names apache/superset#5368)
  3. It fixes csv schema_name upload bugs (fix csv upload schema_name bug apache/superset#5940)

tested on devbox

@airbnb/superset-fork-maintainers

@timifasubaa timifasubaa changed the title More csv changes Cherrypick more csv changes Sep 20, 2018
@codecov-io
Copy link

Codecov Report

Merging #117 into airbnb-master will increase coverage by 0.03%.
The diff coverage is 14.28%.

Impacted file tree graph

@@                Coverage Diff                @@
##           airbnb-master     #117      +/-   ##
=================================================
+ Coverage          63.23%   63.27%   +0.03%     
=================================================
  Files                363      363              
  Lines              22255    22258       +3     
  Branches            2503     2503              
=================================================
+ Hits               14073    14083      +10     
+ Misses              8170     8163       -7     
  Partials              12       12
Impacted Files Coverage Δ
superset/db_engine_specs.py 51.02% <14.28%> (+0.76%) ⬆️
superset/connectors/sqla/models.py 78.04% <0%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f48eddf...f939b7a. Read the comment docs.

@timifasubaa timifasubaa merged commit bb2b51b into airbnb-master Sep 20, 2018
@john-bodley john-bodley deleted the more_csv_changes branch December 4, 2019 02:04
michellethomas pushed a commit that referenced this pull request Dec 1, 2021
michellethomas pushed a commit that referenced this pull request Dec 1, 2021
* feat: add labelFlush to definition

* feat: implement flushing
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants