Cherrypick a few fixes #7

graceguo-supercat · 2018-02-05T19:28:24Z

[explore] fix missing CacheLabel ([explore] fix missing CacheLabel apache/superset#4326)
Refactor import csv (Refactor import csv apache/superset#4298)
[bug] fix JS error when interactive with loading filter_box ([bug] fix JS error when interactive with loading filter_box apache/superset#4339)

@michellethomas @john-bodley @timifasubaa

Also adding a basic unit test. (cherry picked from commit 1f8fccc)

* move helpers to utils * make form use queryselector * refactor exception throwing and handling * update db_connection access point * nits (cherry picked from commit 6d37d97)

2. should show chart after loading completed (cherry picked from commit e965f95)

michellethomas · 2018-02-05T20:15:57Z

lgtm

timifasubaa · 2018-02-05T20:24:24Z

LGTM

* [core][deps] remove unused deps * [core][test] add test for response.ok=false * [core] support csrf_token='' * [core][tests] move mock to sole function that uses it

) * fix(legacy-preset-chart-nvd3): redraw bar values after legend change * fix(legacy-preset-chart-nvd3): avoid creating multiple nodes * fix(legacy-preset-chart-nvd3): improve remove

mistercrunch and others added 3 commits February 5, 2018 10:53

[explore] fix missing CacheLabel (apache#4326)

4a135c5

Also adding a basic unit test. (cherry picked from commit 1f8fccc)

Refactor import csv (apache#4298)

ff2bff9

* move helpers to utils * make form use queryselector * refactor exception throwing and handling * update db_connection access point * nits (cherry picked from commit 6d37d97)

1. fix check filters change logic (apache#4339)

d2bb6cd

2. should show chart after loading completed (cherry picked from commit e965f95)

michellethomas approved these changes Feb 5, 2018

View reviewed changes

graceguo-supercat merged commit 601fe7c into airbnb:airbnb-master Feb 5, 2018

graceguo-supercat deleted the gg-CherryPickFixJSError branch March 7, 2018 19:18

michellethomas pushed a commit that referenced this pull request Dec 1, 2021

[core] support empty CSRF token (#7)

f5d62e3

* [core][deps] remove unused deps * [core][test] add test for response.ok=false * [core] support csrf_token='' * [core][tests] move mock to sole function that uses it

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cherrypick a few fixes #7

Cherrypick a few fixes #7

graceguo-supercat commented Feb 5, 2018 •

edited

Loading

michellethomas commented Feb 5, 2018

timifasubaa commented Feb 5, 2018

Cherrypick a few fixes #7

Cherrypick a few fixes #7

Conversation

graceguo-supercat commented Feb 5, 2018 • edited Loading

michellethomas commented Feb 5, 2018

timifasubaa commented Feb 5, 2018

graceguo-supercat commented Feb 5, 2018 •

edited

Loading