Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[events] make it easier to convert event coords to local to svg coords #15

Closed
hshoff opened this issue May 8, 2017 · 2 comments
Closed
Milestone

Comments

@hshoff
Copy link
Member

hshoff commented May 8, 2017

I've got a localPoint util that requires a reference to the svg node https://github.com/hshoff/vx/blob/master/packages/vx-event/src/localPoint.js

but I'd like to make this easier to use/remove the boilerplate of converting the brush event coordinates to local coordinates.

@hshoff hshoff added this to the v1 milestone May 8, 2017
@erikfox
Copy link

erikfox commented Jun 26, 2017

Is it safe to assume that this is a prerequisite to #44 ?

@hshoff
Copy link
Member Author

hshoff commented Jun 26, 2017

@erikfox yes, it would be if we want tooltips to be svg based.

I'm considering using a react portal outside the svg that would be div based, so we could just use event coords for positioning on on top of the svg. In that case, this wouldn't be a prereq to #44.

hshoff added a commit that referenced this issue Oct 6, 2017
[event] add touchEvt support to localPnt, find owner svg. fixes #15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants