fix(grid): refactor imports to not cause de-optimization for esm bundlers #1298
Conversation
… esm bundlers. When importing from `@visx/grid/lib/shapes/Line` it forces bundlers to use the CommonJS version instead the ECMAScript Module version which leads to larger bundle sizes due to lacking tree-shaking capabilities (commonjs uses `require` statements). If the types are not exposed from the root barrel file they should reside in their own import as type imports will be omitted.
|
Hey @lukasholzer 👋 thanks for the contribution! this is great, and we could probably update more than the looks like this syntax was introduced in TS 3.8 which is what we're on currently, but seems like |
williaster
changed the title
|
Hey @lukasholzer wanted to check back on this. Our TS version should now support this syntax. |
|
Hey @lukasholzer @williaster it would be great to see this MR merged. Is there anything outstanding that needs to be checked/tested that I could assist with? |
|
hi @lukasholzer @ximenean happy to attempt a merge, CI is still failing so it needs to be rebased as a start |
|
@williaster looks like the rebase has no conflicts so no issues there |
🚀 Enhancements
When importing from
@visx/grid/lib/shapes/Lineit forces bundlers to use the CommonJS version instead of the ECMAScript Module version which leads to larger bundle sizes due to lacking tree-shaking capabilities (CommonJS usesrequirestatements).If the types are not exposed from the root barrel file they should reside in their own import as type imports will be omitted.