feat(demo): add radial bars demo using Arc #1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great! thanks for the addition, will try to review in the next couple of days (quick glance looks great) 
|
williaster
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
looks great, excited for it to be live (will be once CI finishes on merge). thanks again @adamzuch 🙌
| return width < 10 ? null : ( | ||
| <> | ||
| <svg width={width} height={height}> | ||
| <GradientLightgreenGreen id="green" /> |
There was a problem hiding this comment.
this id is probably okay, on the gallery page with all examples, this should be unique or could potentially conflict (if I see anything can easily fix)
|
🎉 This PR is included in version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Enhancements
Added a simple radial bar chart demo to the gallery for #832.
Happy to hear any feedback and make changes if necessary. I tried to follow the other demos in the gallery as a guide.