fix(axis): include defaultTextProps in Axis labelProps #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables passing of partial labelProps per the docs.
williaster
reviewed
Jan 19, 2024
There was a problem hiding this comment.
Thanks for the fix here/making it consistent with tickLabelProps! (that behavior was added relatively recently in #1662)
Technically this could be thought of as a breaking change as it would change existing behavior if consumers expect to provide all props. However for tickLabelProps we just made it a minor version bump so we can do that here. I agree this is a better dev x.
williaster
reviewed
Jan 19, 2024
Co-authored-by: Chris Williams <williaster@users.noreply.github.com>
|
Thanks @williaster! Suggested changes applied. |
williaster
reviewed
Jan 24, 2024
Co-authored-by: Chris Williams <williaster@users.noreply.github.com>
williaster
reviewed
Jan 24, 2024
Co-authored-by: Chris Williams <williaster@users.noreply.github.com>
williaster
changed the title
williaster
approved these changes
Jan 25, 2024
|
🎉 This PR is included in version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
Closes #1790