new(vx-react-spring): add AnimatedGridRows/Columns + animationTrajectory #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williaster
commented
Aug 21, 2020
| : [new Date('2020-02-01'), new Date('2020-03-01')]; | ||
| const logValues = dataToggle ? [1, 10, 100, 1000, 10000] : [0.0001, 0.001, 0.1, 1, 10, 100]; | ||
| const axes: AxisDemoProps<AxisScale<number>>[] = useMemo(() => { | ||
| // toggle between two value ranges to demo animation |
There was a problem hiding this comment.
all just indented to memoize
williaster
commented
Aug 21, 2020
|
|
||
| // In order to plot values on an axis, output of the scale must be number. | ||
| // Some scales return undefined. | ||
| export type GridScaleOutput = number | NumberLike | undefined; |
There was a problem hiding this comment.
updated this to match AxisScaleOutput because it simplifies the types in this PR (and logically they should be the same)
williaster
commented
Aug 21, 2020
| }: TicksRendererProps<Scale> & Pick<TransitionConfig<Scale>, 'animationTrajectory'>) { | ||
| const animatedTicks = useTransition(ticks, tick => `${tick.value}-${horizontal}`, { | ||
| unique: true, | ||
| ...useLineTransitionConfig({ scale, animateXOrY: horizontal ? 'x' : 'y', animationTrajectory }), |
There was a problem hiding this comment.
this + the <> wrapper below are the only updates in this file. AnimatedTicks was previously a directory and the indentation with <> made git think it's a new file
williaster
commented
Aug 21, 2020
packages/vx-react-spring/src/spring-configs/useLineTransitionConfig.ts
Outdated
Show resolved
Hide resolved
williaster
force-pushed
the
chris--animated-grid
branch
from
084680e
to
d64d86f
Compare
…dLines, demo improvements
williaster
force-pushed
the
chris--animated-grid
branch
from
0dd5ba3
to
c70b093
Compare
woot! |
hshoff
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO::
🚀 Enhancements
Part of the
XYChartproject, this PR[
@vx/grid]childrenprop toGridRows+GridColumnsto support animated rendering[
@vx/react-spring]AnimatedGridRows+AnimatedGridColumnsAnimatedTicks/useAnimatedTicksConfigtospring-configs/useAnimatedLineTransitionConfigso it can power both animated tick + grid linesanimationTrajectory=outside | inside | min | maxtoAnimatedAxisandAnimatedGridRows/Columns[
@vx/demo]/axisdemo to includeAnimatedGrid*and aanimationTrajectoryconfig💥 Breaking Changes
[
@vx/grid]GridColumnProps=>GridColumnsProps(+s) to matchGridRowsProps@hshoff @kristw @techniq