fix(demo/text): render 0 as number (#813)

[ilariaventurini]

🐛 Bug Fix

• closes: @vx/text doesn't work with 0 as a number #813

[coveralls]

Pull Request Test Coverage Report for Build 32

Details

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• 4 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.03%) to 54.34%

---

Files with Coverage Reduction	New Missed Lines	%
packages/visx-text/src/Text.tsx	4	73.64%

Totals
Change from base Build 269438902:	-0.03%
Covered Lines:	1099
Relevant Lines:	1976

---

💛 - Coveralls

[hshoff]

Thanks for the contribution! Looks good to me.

[williaster]

@ilariaventurini thanks for the fix!

looks like the build is failing due to eslint errors. The seem to all be auto-fixable so if you run yarn lint --fix from the monorepo root it should fix everything ✨

[ilariaventurini]

I edited the code using props.children !== null (as @williaster suggested me) instead of props.children !== null && props.children !== undefined.
Tests all pass.
Then I tried running yarn fix:lint but I get this error:

/Users/ilariaventurini/.../visx/packages/visx-text/src/Text.tsx
119:11  error  Unexpected negated condition  no-negated-condition
141:7   error  Unexpected negated condition  no-negated-condition

So the build is failing.

[williaster]

Hey @ilariaventurini , sorry for the misdirection in suggestiong eslint --fix, it looks like that converted a lot of TypeScript anys to unknown which aren't equivalent, and now failed the build.

I think it's probably easiest to revert back to your first commit 9f98551, and then apply my suggested fix to reverse the negated condition. Then this should be good to go 🙏

[williaster]

!= I think is still ideal, but there is another lint rule which favors not having negated conditions (because they are harder to understand logically). So I think this should fix things:

Suggested change

	const words = (props.children !== null && props.children !== undefined) ? props.children.toString().split(/(?:(?!\u00A0+)\s+)/) : [];
	const words = props.children == null ? [] : props.children.toString().split(/(?:(?!\u00A0+)\s+)/);

[williaster]

@ilariaventurini sorry looks like you still have all the auto lint fix stuff in here. when I said revert back to your first commit I meant run git reset --hard 9f98551.

That commit had lint issues, so from there you should simply be able to make the change to const words = props.children == null ? [] : props.children.toString().split(/(?:(?!\u00A0+)\s+)/) then force push your branch.

[williaster]

Thanks @ilariaventurini !