new(xychart): add BarGroup #870
Conversation
| @@ -56,28 +58,48 @@ export default function Example({ height }: Props) { | |||
| numTicks={numTicks} | |||
| /> | |||
| {renderBarStack && ( | |||
| <g fillOpacity={renderLineSeries ? 0.5 : 1}> | |||
There was a problem hiding this comment.
g element wasn't used
| const groupScale = useMemo( | ||
| () => | ||
| scaleBand<string>({ | ||
| domain: [...dataKeys], // @TODO order |
There was a problem hiding this comment.
reminder to myself to add this prop
|
|
||
| // try to figure out the 0 baseline for correct rendering of negative values | ||
| // we aren't sure if these are numeric scales or not ahead of time | ||
| const maybeXZero = xScale(0) ?? 0; |
There was a problem hiding this comment.
some of this is duplicated in BarSeries. I'm going to focus on animated bars next, and will try to remove some of the duplication.
Pull Request Test Coverage Report for Build 214
💛 - Coveralls |
| <g className="visx-bar-group"> | ||
| {registryEntries.map(({ xAccessor, yAccessor, data, key }) => | ||
| data.map((datum, index) => { | ||
| const barLength = horizontal |
There was a problem hiding this comment.
similar to suggestion on barstack, these conditions can be moved outside to save n times redundant check.
williaster
force-pushed
the
chris--xychart-stackedbar-tests
branch
from
406603f to
6ec13a9
Compare
new(demo/xychart): add BarGroup new(xychart/BarGroup): add mouseover/out fix(demo/xychart): better ux new(xychart/BarGroup): add sortBars internal(xychart/BarGroup): add perf improvements
williaster
force-pushed
the
chris--xychart-grouped-bar
branch
from
4d3d30c to
d6d09c0
Compare
* test(xychart/mocks): add @visx/event mock * test(xychart): add BarGroup tests * test(xychart): add mousemove/out tests to all series * test(xychart): remove .test. from setupTooltipTest filename * lint(xychart/setupTooltipTest)
|
@williaster hello. can I use this in the latest version of library? |
|
Hey @r0st1kuzh , sorry we have not published the It should be ready for publishing in the next couple of weeks, tho. I created #884 to track it (or you can follow the |
TODO
masterwhenBarStacknew(xychart): add BarStack series #865 is merged🚀 Enhancements
This adds a
BarGroupseries to@visx/xychartwhich supports tooltips, negative values, and horizontal rendering like other*Series. It updates the/xychartdemo to include it.@kristw @techniq