Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new(xychart): add (Animated)GlyphSeries #885

Merged
merged 10 commits into from
Oct 23, 2020
Merged

new(xychart): add (Animated)GlyphSeries #885

merged 10 commits into from
Oct 23, 2020

Conversation

williaster
Copy link
Collaborator

🚀 Enhancements

This PR

  • adds GlyphSeries, AnimatedGlyphSeries, and BaseGlyphSeries for a common implementation
    • both GlyphSeries and AnimatedGlyphSeries allow customization of the renderGlyph component, which defaults to a circle (defaultRenderGlyph)
  • adds tests for new files
  • updates the /xychart demo to optionally render the AnimatedGlyphSeries

@kristw @techniq

williaster
williaster commented Oct 21, 2020
View reviewed changes
packages/visx-xychart/src/components/series/AnimatedGlyphSeries.tsx
{...props}
// @TODO currently generics for non-SeriesProps are not passed correctly in
// withRegisteredData HOC
// @ts-ignore
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is tricky ... I added an item to the project tracker to address later

@williaster williaster added this to the 1.1.1 milestone Oct 22, 2020
@coveralls
Copy link

coveralls commented Oct 22, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 262

  • 43 of 46 (93.48%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 60.588%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/visx-react-spring/src/grid/AnimatedGridLines.tsx 0 1 0.0%
packages/visx-xychart/src/components/series/private/AnimatedGlyphs.tsx 11 13 84.62%
Totals Coverage Status
Change from base Build 260: 0.3%
Covered Lines: 1535
Relevant Lines: 2421
💛 - Coveralls

Base automatically changed from chris--xychart-area to master October 22, 2020 23:36
@williaster williaster merged commit 4c34c97 into master Oct 23, 2020
@williaster williaster deleted the chris--xychart-glyphs branch October 23, 2020 17:49
@coveralls
Copy link

coveralls commented Nov 24, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 253

Details

  • 43 of 46 (93.48%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 60.588%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/visx-react-spring/src/grid/AnimatedGridLines.tsx 0 1 0.0%
packages/visx-xychart/src/components/series/private/AnimatedGlyphs.tsx 11 13 84.62%
Totals Coverage Status
Change from base Build 238: 0.3%
Covered Lines: 1535
Relevant Lines: 2421
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hshoff hshoff hshoff approved these changes

@kristw kristw Awaiting requested review from kristw

Assignees
No one assigned
Labels
💨 animation 🚀enhancement @visx/xychart
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@williaster @coveralls @hshoff