test(xychart): add missing data tests #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williaster
force-pushed
the
chris--xychart-data-tests
branch
from
6cc43b0 to
8b75a4e
Compare
Pull Request Test Coverage Report for Build 344442545
💛 - Coveralls |
williaster
force-pushed
the
chris--xychart-data-tests
branch
from
9aa7189 to
9e88764
Compare
hshoff
requested changes
Nov 3, 2020
| @@ -169,6 +169,8 @@ export default function BaseBarGroup< | |||
| .filter(bar => bar) as Bar[]; | |||
| }); | |||
|
|
|||
| console.log(bars); | |||
There was a problem hiding this comment.
🤦 thanks for the catch
williaster
force-pushed
the
chris--xychart-data-tests
branch
from
3afc1d9 to
627220d
Compare
hshoff
approved these changes
Nov 5, 2020
Pull Request Test Coverage Report for Build 341Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏠 Internal
This PR adds tests for missing data additions in #898
@kristw