-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(xychart): add README, add docs/xychart page, add XYChart gallery tile #963
Conversation
Pull Request Test Coverage Report for Build 421994739Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
hmm, may not be able to cleanly create the |
d0f7163
to
5b24ea7
Compare
Going to merge this since it's been open for a while and is just docs w(hich are blocking |
📝 Documentation
This PR
README
for@visx/xychart
to cover most aspects of the API, including some example code snippets<details />
sections so that the rest of the/docs/xychart
page with example tile(s) + comprehensive API will be visible without needed to scroll a lot/docs/xychart
page to the demo site, and theXYChartTile
to the gallery 🎉I plan to add a couple more examples but non-gallery codesandboxes will be easier to create when the package is published
@kristw @hshoff