thread_pool: create a new thread group per process #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrylo
force-pushed
the
576-enclosed-thread-group-fix
branch
2 times, most recently
from
b31d9e3 to
92f8ff9
Compare
Fixes #576 (ThreadError: can't move to the enclosed thread group) When we `Airbrake.notify` inside a `fork` block, `ThreadPool` tries to respawn workers (which were killed by the `fork`) to the same `ThreadGroup`, which was created in the parent process. The problem is that that `ThreadGroup` is already finalised in that parent process and no new threads can be added anymore to the group. The fix is to create a new `ThreadGroup` on `fork`. This way every process will have its own `ThreadGroup`.
kyrylo
force-pushed
the
576-enclosed-thread-group-fix
branch
from
92f8ff9 to
f9054be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #576 (ThreadError: can't move to the enclosed thread group)
When we
Airbrake.notifyinside aforkblock,ThreadPooltries to respawnworkers (which were killed by the
fork) to the sameThreadGroup, which wascreated in the parent thread. The problem is that that
ThreadGroupis alreadyfinalised in that parent thread and no new threads can be added anymore. The
fix is to create a new
ThreadGrouponfork. This way every process will haveits own
ThreadGroup.