Update pickup_vrp API to be in par with the rest of the library #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method optimize_model() can be reused in pickup_vrp LP solvers, where we need to iterate over it without retrieving directly GPDPDSolution (which forget about some necessary attributes in the loop).
- Iterative solving of using Mip library has some strange behaviour, leading to unfeasible problems. - This commit permits to circumvent the issue by reinitializing the TSP linear model at each iteration of the algo - To keep in memory subtour elimination constraints, we store the necessary info in pure python object (list_constraints_tuple), the constraint can be reintroduced from a clean model. - This patch is not very efficient when the LP is large to initialize.
It was specific to usecase, not tested, and deprecated.
|
as discussed, this PR is satisfactory and we identified some things to code further (better satisfy function for gpdp problem) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solve()does return aResultStorage.What this PR does not solve:
LinearFlowSolverVehicleTypeare unfinished