Fix optuna callback #190
Merged
Fix optuna callback #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optuna callback was relying on `ResultStorage.best_fit` to get the current best fitness. But this property is correctly filled only if the result_storage has been filled using `add_solution()`. And lost of solvers actually directly append solutions to the attribute `ResultSorage.list_solution_fits`. So we rather use `ResultStorage_get_best_solution_fit()` which works always.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optuna callback was relying on
ResultStorage.best_fitto get the current best fitness. But this property is correctly filled only if the result_storage has been filled usingadd_solution(). And lost of solvers actually directly append solutions to the attributeResultSorage.list_solution_fits.So we rather use
ResultStorage_get_best_solution_fit()which works always.