Simplification of ResultStorage api #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhuet
force-pushed
the
resultstorage
branch
2 times, most recently
from
199a8d8 to
b55f879
Compare
- attributes restricted to - list_solution_fits - mode_optim - maximize - remove add_solution() that was pre-computing current best_solution - derive now from MutableSequence so that one can - iterate over it - set/get/delete an item - append to it, extend it - compute its length such operations are actually performed on the underlying list_solution_fits attribute - list_solution_fits can be omitted during initialization -> will be [] - mode_optim is now a mandatory argument Add SolverDO.create_result_storage() to automatically specify mode_optim.
g-poveda
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attributes restricted to
list_solution_fitsmode_optimmaximizeremove
add_solution()that was pre-computing current best_solutionderive now from
MutableSequenceso that one cansuch operations are actually performed on the underlying
list_solution_fitsattributelist_solution_fitscan be omitted during initialization -> will be[]mode_optimis now a mandatory argumentAdd
SolverDO.create_result_storage()to automatically specifymode_optim.