Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New knapsack solver based on cpmpy library #63

Merged
merged 3 commits into from
Oct 21, 2022
Merged

New knapsack solver based on cpmpy library #63

merged 3 commits into from
Oct 21, 2022

Conversation

g-poveda
Copy link
Collaborator

  • Adding a wrapper solver for knapsack using the CP modeling library in python https://github.com/CPMpy/cpmpy
  • Adding example to run and unit test
  • adding cpmpy as dependency

nhuet
nhuet approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@nhuet nhuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me

examples/knapsack/knapsack_cpmyp.py
Comment on lines 4 to 6
import logging

from discrete_optimization.generic_tools.cp_tools import ParametersCP
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not very important, but should be part of previous commit.

@g-poveda g-poveda merged commit 04924bc into airbus:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhuet nhuet nhuet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g-poveda @nhuet